Zendesk tickets #2192
Merged
Zendesk tickets #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwjordan is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
|
@yuhongsun96 Any chance you'd be able to review this PR? Thanks! |
|
Hello! I will find time to look through it today! Thanks for your contribution! |
yuhongsun96
force-pushed
the
zendesk-tickets
branch
from
f12d576
to
cc2975c
Compare
8 tasks
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
rajivml
pushed a commit
to UiPath/danswer
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the Zendesk connector to support a new required dropdown selection between "articles" and "tickets" with "articles" as the default for backward compatibility. If you already have a Zendesk connector set up, it will continue to work normally. If you set up a new one, you can choose "tickets" to have that connector sync all non-deleted Zendesk tickets. Therefore, you have the ability to create two separate Zendesk connectors using the same shared credentials, one for articles and one for tickets, which I felt would be useful in the creation of different Document Sets down the line (If you want both in the same Document Set, you can, but you can also easily separate knowledge of articles and tickets in the case where you want a Sales Assistant that only trains on articles, but a Support Assistant that trains on both articles and tickets).
How Has This Been Tested?
I tested this against my own Zendesk account by setting up the original Zendesk connection for articles, making code changes, and verifying that I can sync tickets properly. I then queried against known ticket contents to verify that Chat and Search work, and also verified that the citation links properly open the Agent view of the Zendesk ticket in a new browser tab. Finally I tested deletion of the new "tickets" connector and verified it had no effect on the pre-existing "articles" connector.
Accepted Risk
None that I'm aware of.
Related Issue(s)
I don't believe this feature request was recorded as an issue.
Checklist: